Skip to content

fix: prevent hotkeys when typing in monaco editor #2303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: prevent hotkeys when typing in monaco editor #2303

wants to merge 3 commits into from
+40 −1

Conversation

QuentinRoy
Copy link
Contributor

Prevent Slidev hotkeys from triggering when typing in the editor in Chromium-based browsers.

Fixes #2297.

@netlify Netlify
Copy link

netlify bot commented Oct 9, 2025 •
edited
Loading

✅ Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 06bf13b
🔍 Latest deploy log https://app.netlify.com/projects/slidev/deploys/68e8d095ddebdf00085a7246
😎 Deploy Preview https://deploy-preview-2303--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 9, 2025 •
edited
Loading

Open in StackBlitz

@slidev/client

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/client@2303

create-slidev

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev@2303

create-slidev-theme

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@2303

@slidev/parser

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/parser@2303

@slidev/cli

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/cli@2303

@slidev/types

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/types@2303

commit: 06bf13b

@QuentinRoy QuentinRoy force-pushed the new-monaco-fix branch 2 times, most recently from 0801eed to 0e44e99 Compare October 9, 2025 10:54
@QuentinRoy QuentinRoy force-pushed the new-monaco-fix branch 2 times, most recently from 6f41012 to 74ee58c Compare October 9, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hotkeys triggered when editing monaco editor in Chromium-based browsers
1 participant
@QuentinRoy